From 938bbff1243400401d534174301939fdd2c59cb9 Mon Sep 17 00:00:00 2001 From: "Christopher R. Hertel (crh)" Date: Fri, 14 Feb 2014 11:41:24 -0600 Subject: [PATCH] regedit_valuelist.c: Coverity fix; Initialize a variable. The variable is tested at the end of the function to determine the return value, but is never initialized and there are conditions under which it may be tested before a value is set. This patch initializes to NULL, which means that WERR_NOMEM will be returned if the registry lookups fail. CID: 1168007 Signed-off-by: Christopher R. Hertel (crh) Reviewed-by: Jeremy Allison --- source3/utils/regedit_valuelist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/utils/regedit_valuelist.c b/source3/utils/regedit_valuelist.c index 4d21be54168..b135159ed92 100644 --- a/source3/utils/regedit_valuelist.c +++ b/source3/utils/regedit_valuelist.c @@ -169,7 +169,7 @@ static bool string_is_printable(const char *s) static WERROR append_data_summary(struct value_item *vitem) { - char *tmp; + char *tmp = NULL; /* This is adapted from print_registry_value() in net_registry_util.c */ -- 2.11.4.GIT