From 910b0ce2a2e0d671c27a88176ed00e8995669773 Mon Sep 17 00:00:00 2001 From: =?utf8?q?G=C3=BCnther=20Deschner?= Date: Sat, 28 Oct 2017 11:10:07 +0200 Subject: [PATCH] s4-torture: remove obsolete comment in libsmbclient torture suite. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Since smbc_setX calls now handle string allocation using malloc themselves (since commit 2d41b1ab78639abe4ae030ff482573f464564dd7) we indeed no longer need to provide malloced strings (the extra malloc already got removed earlier). Guenther Signed-off-by: Günther Deschner Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Mon Oct 30 21:09:14 CET 2017 on sn-devel-144 --- source4/torture/libsmbclient/libsmbclient.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/source4/torture/libsmbclient/libsmbclient.c b/source4/torture/libsmbclient/libsmbclient.c index 16ad35182cd..a56a5de55d7 100644 --- a/source4/torture/libsmbclient/libsmbclient.c +++ b/source4/torture/libsmbclient/libsmbclient.c @@ -36,8 +36,6 @@ bool torture_libsmbclient_init_context(struct torture_context *tctx, smbc_setDebug(ctx, DEBUGLEVEL); smbc_setOptionDebugToStderr(ctx, 1); - /* yes, libsmbclient API frees the username when freeing the context, so - * have to pass malloced data here */ smbc_setUser(ctx, cli_credentials_get_username(popt_get_cmdline_credentials())); -- 2.11.4.GIT