From 88db634ed84647e5105c4b4fdf37d5892bebfd8d Mon Sep 17 00:00:00 2001 From: Arvid Requate Date: Thu, 22 Jun 2017 13:37:13 +0200 Subject: [PATCH] s4-dsdb/netlogon: allow missing ntver in cldap ping BUG: https://bugzilla.samba.org/show_bug.cgi?id=11392 Signed-off-by: Arvid Requate Reviewed-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- selftest/knownfail.d/huawei | 1 - source4/dsdb/samdb/ldb_modules/netlogon.c | 6 +----- 2 files changed, 1 insertion(+), 6 deletions(-) delete mode 100644 selftest/knownfail.d/huawei diff --git a/selftest/knownfail.d/huawei b/selftest/knownfail.d/huawei deleted file mode 100644 index cbeaf68a247..00000000000 --- a/selftest/knownfail.d/huawei +++ /dev/null @@ -1 +0,0 @@ -samba4.ldap.netlogon-udp.netlogon-udp\(ad_dc_ntvfs\) diff --git a/source4/dsdb/samdb/ldb_modules/netlogon.c b/source4/dsdb/samdb/ldb_modules/netlogon.c index c5f194dc4dc..f7ba2ac041c 100644 --- a/source4/dsdb/samdb/ldb_modules/netlogon.c +++ b/source4/dsdb/samdb/ldb_modules/netlogon.c @@ -425,7 +425,7 @@ NTSTATUS parse_netlogon_request(struct ldb_parse_tree *tree, *domain_guid = NULL; *domain_sid = NULL; *acct_control = -1; - *version = -1; + *version = 0; if (tree->operation != LDB_OP_AND) goto failed; @@ -486,10 +486,6 @@ NTSTATUS parse_netlogon_request(struct ldb_parse_tree *tree, *domain = lpcfg_dnsdomain(lp_ctx); } - if (*version == -1) { - goto failed; - } - return NT_STATUS_OK; failed: -- 2.11.4.GIT