From 86f3f49c6013144854bd9bf95b755e985c06462c Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Mon, 17 Dec 2012 15:31:21 +0100 Subject: [PATCH] s3-rpc_server: Fix a possible null pointer dereference. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This variable can be set to NULL in an earlier function call. Found by Coverity. Signed-off-by: Andreas Schneider Reviewed-by: Günther Deschner (cherry picked from commit 72e02c73b64f1ff56b2d53ec63d68486a4f1ff90) (cherry picked from commit 43810c80936c8f509cc2adba6193dd4c55325875) --- source3/rpc_server/spoolss/srv_spoolss_nt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c index b5949e44cc5..35ebe578eee 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c @@ -4442,7 +4442,8 @@ static WERROR enum_all_printers_info_1_name(TALLOC_CTX *mem_ctx, DEBUG(4,("enum_all_printers_info_1_name\n")); - if ((servername[0] == '\\') && (servername[1] == '\\')) { + if (servername != NULL && + (servername[0] == '\\') && (servername[1] == '\\')) { s = servername + 2; } -- 2.11.4.GIT