From 7f8c8d80ef6553dc28f0bf6d9aa7a2c46ab55529 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Mon, 17 Dec 2012 14:21:01 +0100 Subject: [PATCH] s3-tldap: Fix dead code in tldap_sasl_bind_send(). MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit dn can't be NULL cause it is set to "" in that case. Found by Coverity. Signed-off-by: Andreas Schneider Reviewed-by: Günther Deschner --- source3/lib/tldap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/lib/tldap.c b/source3/lib/tldap.c index 8b04d006367..765580fd81d 100644 --- a/source3/lib/tldap.c +++ b/source3/lib/tldap.c @@ -817,7 +817,7 @@ struct tevent_req *tldap_sasl_bind_send(TALLOC_CTX *mem_ctx, asn1_push_tag(state->out, TLDAP_REQ_BIND); asn1_write_Integer(state->out, ld->ld_version); - asn1_write_OctetString(state->out, dn, (dn != NULL) ? strlen(dn) : 0); + asn1_write_OctetString(state->out, dn, strlen(dn)); if (mechanism == NULL) { asn1_push_tag(state->out, ASN1_CONTEXT_SIMPLE(0)); -- 2.11.4.GIT