From 7cfe6e91177e93f80d4d7e02d1414ca80641e13c Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Fri, 19 Dec 2014 16:02:40 +1300 Subject: [PATCH] lib/ldb-samba: Add comment dicouraging use of schemaUpgradeInProgress Signed-off-by: Garming Sam Pair-programmed-with: Garming Sam Signed-off-by: Andrew Bartlett Autobuild-User(master): Garming Sam Autobuild-Date(master): Mon Dec 22 02:42:42 CET 2014 on sn-devel-104 --- lib/ldb-samba/tests/match_rules.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/ldb-samba/tests/match_rules.py b/lib/ldb-samba/tests/match_rules.py index cb18248f169..6b31392df1d 100755 --- a/lib/ldb-samba/tests/match_rules.py +++ b/lib/ldb-samba/tests/match_rules.py @@ -209,6 +209,16 @@ class MatchRulesTests(samba.tests.TestCase): # |-> c1 # | |->c2 # | | |->u1 + + # + # While appropriate for this test, this is NOT a good practice + # in general. This is only done here because the alternative + # is to make a schema modification. + # + # IF/WHEN Samba protects this attribute better, this + # particular part of the test can be removed, as the same code + # is covered by the addressBookRoots2 case well enough. + # m = Message() m.dn = Dn(self.ldb, "") m["e1"] = MessageElement("1", FLAG_MOD_REPLACE, "schemaUpgradeInProgress") -- 2.11.4.GIT