From 763d37e6a4ba7121e940a95e56502180c13e363e Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Fri, 26 Sep 2014 13:25:41 +0200 Subject: [PATCH] libcli: Remove unreachable code in cldap. Signed-off-by: Andreas Schneider Reviewed-by: Michael Adam --- libcli/cldap/cldap.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libcli/cldap/cldap.c b/libcli/cldap/cldap.c index eb4f102e6ab..df81767a760 100644 --- a/libcli/cldap/cldap.c +++ b/libcli/cldap/cldap.c @@ -919,9 +919,7 @@ char *cldap_netlogon_create_filter(TALLOC_CTX *mem_ctx, } if (io->in.domain_sid) { struct dom_sid *sid = dom_sid_parse_talloc(mem_ctx, io->in.domain_sid); - if (filter == NULL) { - return NULL; - } + filter = talloc_asprintf_append_buffer(filter, "(domainSid=%s)", ldap_encode_ndr_dom_sid(mem_ctx, sid)); if (filter == NULL) { @@ -931,9 +929,7 @@ char *cldap_netlogon_create_filter(TALLOC_CTX *mem_ctx, if (io->in.domain_guid) { struct GUID guid; GUID_from_string(io->in.domain_guid, &guid); - if (filter == NULL) { - return NULL; - } + filter = talloc_asprintf_append_buffer(filter, "(DomainGuid=%s)", ldap_encode_ndr_GUID(mem_ctx, &guid)); if (filter == NULL) { -- 2.11.4.GIT