From 6cc8d7880d3c22d6cf680efae3cf4079daec7f0b Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Mon, 15 May 2017 17:36:17 +0200 Subject: [PATCH] s4:rpc_server: remove useless TALLOC_FREE(call->context) from dcesrv_bind() This is not needed if we're terminating the connection anyway. Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett --- source4/rpc_server/dcerpc_server.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/source4/rpc_server/dcerpc_server.c b/source4/rpc_server/dcerpc_server.c index 0a8e7e5196b..34de07171e6 100644 --- a/source4/rpc_server/dcerpc_server.c +++ b/source4/rpc_server/dcerpc_server.c @@ -965,8 +965,6 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call) if (!dcesrv_auth_bind(call)) { struct dcesrv_auth *auth = &call->conn->auth_state; - TALLOC_FREE(call->context); - if (auth->auth_level == DCERPC_AUTH_LEVEL_NONE) { /* * With DCERPC_AUTH_LEVEL_NONE, we get the @@ -1014,7 +1012,6 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call) ep_prefix, endpoint); if (pkt->u.bind_ack.secondary_address == NULL) { - TALLOC_FREE(call->context); return NT_STATUS_NO_MEMORY; } pkt->u.bind_ack.num_results = call->pkt.u.bind.num_contexts; @@ -1023,20 +1020,17 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call) status = dcesrv_auth_bind_ack(call, pkt); if (!NT_STATUS_IS_OK(status)) { - TALLOC_FREE(call->context); return dcesrv_bind_nak(call, 0); } rep = talloc_zero(call, struct data_blob_list_item); if (!rep) { - TALLOC_FREE(call->context); return NT_STATUS_NO_MEMORY; } status = ncacn_push_auth(&rep->blob, call, pkt, call->out_auth_info); if (!NT_STATUS_IS_OK(status)) { - TALLOC_FREE(call->context); return status; } -- 2.11.4.GIT