From 692d9c912775003991435a0057a63b4da3be60e6 Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Tue, 28 Apr 2015 11:01:13 +1200 Subject: [PATCH] KCC: improve docstring and comment for kcc.remove_unneeded_ntdsconn() Signed-off-by: Douglas Bagnall Reviewed-by: Garming Sam Reviewed-by: Andrew Bartlett --- source4/scripting/bin/samba_kcc | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/source4/scripting/bin/samba_kcc b/source4/scripting/bin/samba_kcc index 78a00c7b9b4..ec089d62ed4 100755 --- a/source4/scripting/bin/samba_kcc +++ b/source4/scripting/bin/samba_kcc @@ -404,12 +404,17 @@ class KCC(object): pass def remove_unneeded_ntdsconn(self, all_connected): - """Removes unneeded NTDS Connections after computation - of KCC intra and inter-site topology has finished. + """Remove unneeded NTDS Connections once topology is calculated + + Based on MS-ADTS 6.2.2.4 Removing Unnecessary Connections + + :param all_connected: indicates whether all sites are connected + :return: None """ mydsa = self.my_dsa - # Loop thru connections + # New connections won't have GUIDs which are needed for + # sorting. Add them. for cn_conn in mydsa.connect_table.values(): if cn_conn.guid is None: if opts.readonly: -- 2.11.4.GIT