From 620091855b535e5260eb2822e37ca8f34f17f9b4 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Mon, 18 Aug 2008 16:17:59 -0700 Subject: [PATCH] Make the change to smbcontrol for "all" to mean broadcast, and "smbd" to mean the main smb daemon. Update docs to match. Jeremy. (cherry picked from commit c361beca1ed4e896151c6445b881b40957cc1ce4) --- docs-xml/manpages-3/smbcontrol.1.xml | 17 +++++++++++++---- source/utils/smbcontrol.c | 7 +++---- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/docs-xml/manpages-3/smbcontrol.1.xml b/docs-xml/manpages-3/smbcontrol.1.xml index d7c7751cbe4..f8c31bb1b91 100644 --- a/docs-xml/manpages-3/smbcontrol.1.xml +++ b/docs-xml/manpages-3/smbcontrol.1.xml @@ -58,23 +58,32 @@ on STDIN. An empty command line or a "q" will quit the program. - + destination One of nmbd, smbd or a process ID. + The all destination causes the + message to "broadcast" to all running daemons including nmbd and + winbind. This is a change for Samba 3.3, prior to this the + paramter smbd used to do this. + The smbd destination causes the - message to "broadcast" to all smbd daemons. + message to be sent to the smbd daemon specified in the + smbd.pid file. The nmbd destination causes the message to be sent to the nmbd daemon specified in the nmbd.pid file. + The winbindd destination causes the + message to be sent to the winbind daemon specified in the + winbindd.pid file. + If a single process ID is given, the message is sent to only that process. - - + message-type Type of message to send. See diff --git a/source/utils/smbcontrol.c b/source/utils/smbcontrol.c index 6699763cd2d..750030d9166 100644 --- a/source/utils/smbcontrol.c +++ b/source/utils/smbcontrol.c @@ -1228,9 +1228,9 @@ static struct server_id parse_dest(const char *dest) struct server_id result = {-1}; pid_t pid; - /* Zero is a special return value for broadcast smbd */ + /* Zero is a special return value for broadcast to all processes */ - if (strequal(dest, "smbd")) { + if (strequal(dest, "all")) { return interpret_pid(MSG_BROADCAST_PID_STR); } @@ -1245,7 +1245,6 @@ static struct server_id parse_dest(const char *dest) dest = "winbindd"; } - if (!(strequal(dest, "winbindd") || strequal(dest, "nmbd"))) { /* Check for numeric pid number */ @@ -1266,7 +1265,7 @@ static struct server_id parse_dest(const char *dest) fprintf(stderr,"Can't find pid for destination '%s'\n", dest); return result; -} +} /* Execute smbcontrol command */ -- 2.11.4.GIT