From 508b45fca93ca2dfb048fdf7465602bc34df42db Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Thu, 26 Mar 2015 13:11:14 +0100 Subject: [PATCH] ctdb: Fix CID 1125615 Copy into fixed size buffer Might be a "can't happen", but strcpy always looks fishy Signed-off-by: Volker Lendecke Reviewed-by: Michael Adam --- ctdb/tests/src/ctdb_test_stubs.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ctdb/tests/src/ctdb_test_stubs.c b/ctdb/tests/src/ctdb_test_stubs.c index 3ea508a0f32..a9947b16f04 100644 --- a/ctdb/tests/src/ctdb_test_stubs.c +++ b/ctdb/tests/src/ctdb_test_stubs.c @@ -597,7 +597,12 @@ int32_t ctdb_control_get_ifaces(struct ctdb_context *ctdb, i = 0; for (cur=ctdb->ifaces;cur;cur=cur->next) { - strcpy(ifaces->ifaces[i].name, cur->name); + size_t nlen = strlcpy(ifaces->ifaces[i].name, cur->name, + sizeof(ifaces->ifaces[i].name)); + if (nlen >= sizeof(ifaces->ifaces[i].name)) { + /* Ignore invalid name */ + continue; + } ifaces->ifaces[i].link_state = cur->link_up; ifaces->ifaces[i].references = cur->references; i++; -- 2.11.4.GIT