From 490bbb96b9bd082a190a590a6137f0e24f80a6e4 Mon Sep 17 00:00:00 2001 From: Gary Lockyer Date: Fri, 7 Feb 2020 10:50:07 +1300 Subject: [PATCH] libprc ndr tests: Fix ndrdump test ntlmssp_CHALLENGE_MESSAGE Fix the expected data in fuzzed_ntlmssp-CHALLENGE_MESSAGE.txt, as it contained source code line numbers. Andrew this test needs to be altered to us a regular expression and remove the dependency on source line numbers. Credit to OSS-Fuzz REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20083 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14236 Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett --- selftest/knownfail.d/bug-14236 | 1 - source4/librpc/tests/fuzzed_ntlmssp-CHALLENGE_MESSAGE.txt | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/selftest/knownfail.d/bug-14236 b/selftest/knownfail.d/bug-14236 index 8131b070b37..e69de29bb2d 100644 --- a/selftest/knownfail.d/bug-14236 +++ b/selftest/knownfail.d/bug-14236 @@ -1 +0,0 @@ -^samba.tests.blackbox.ndrdump.samba.tests.blackbox.ndrdump.NdrDumpTests.test_ndrdump_fuzzed_NULL_struct_ntlmssp_CHALLENGE_MESSAGE diff --git a/source4/librpc/tests/fuzzed_ntlmssp-CHALLENGE_MESSAGE.txt b/source4/librpc/tests/fuzzed_ntlmssp-CHALLENGE_MESSAGE.txt index f489979d173..90879ad923e 100644 --- a/source4/librpc/tests/fuzzed_ntlmssp-CHALLENGE_MESSAGE.txt +++ b/source4/librpc/tests/fuzzed_ntlmssp-CHALLENGE_MESSAGE.txt @@ -38,6 +38,6 @@ pull returned Success TargetInfoLen : 0x0000 (0) TargetInfoMaxLen : 0x0000 (0) TargetInfo : NULL -ndr_push_subcontext_end: ndr_push_error(Subcontext Error): Bad subcontext (PUSH) content_size 1 is larger than size_is(0) at ../../librpc/ndr/ndr.c:905 +ndr_push_subcontext_end: ndr_push_error(Subcontext Error): Bad subcontext (PUSH) content_size 1 is larger than size_is(0) at ../../librpc/ndr/ndr.c:901 push returned Subcontext Error validate push FAILED -- 2.11.4.GIT