From 46fdd6221e9c64b459e0d05e6d02d89deb8dafb5 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Wed, 7 Jan 2015 09:16:57 +0100 Subject: [PATCH] wafsamba: improve -fvisibility=hidden, we should check it together this WERROR_CFLAGS GCC ignores -fvisibility=hidden with a warning instead of failing om some platforms (e.g. Solaris). Bug: https://bugzilla.samba.org/show_bug.cgi?id=11031 Based on a patch from Tom Schulz . Signed-off-by: Stefan Metzmacher Reviewed-by: Ralph Boehme --- buildtools/wafsamba/wscript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildtools/wafsamba/wscript b/buildtools/wafsamba/wscript index 0a1cd1ce3ea..c49b20e1153 100755 --- a/buildtools/wafsamba/wscript +++ b/buildtools/wafsamba/wscript @@ -341,7 +341,7 @@ def configure(conf): else: conf.env.HAVE_LD_VERSION_SCRIPT = False - if conf.CHECK_CFLAGS('-fvisibility=hidden'): + if conf.CHECK_CFLAGS(['-fvisibility=hidden'] + conf.env.WERROR_CFLAGS): conf.env.VISIBILITY_CFLAGS = '-fvisibility=hidden' conf.CHECK_CODE('''int main(void) { return 0; } __attribute__((visibility("default"))) void vis_foo2(void) {}''', -- 2.11.4.GIT