From 3c79f85b6ec8e99bd58e615b692bbef1284fef03 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Thu, 22 Nov 2012 15:34:06 +0100 Subject: [PATCH] util: Use new samba_getpass() function. Reviewed-by: Jelmer Vernooij --- source3/lib/util_cmdline.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/source3/lib/util_cmdline.c b/source3/lib/util_cmdline.c index 440384608bc..d15f32535bf 100644 --- a/source3/lib/util_cmdline.c +++ b/source3/lib/util_cmdline.c @@ -246,7 +246,8 @@ bool set_cmdline_auth_info_machine_account_creds(struct user_auth_info *auth_inf void set_cmdline_auth_info_getpass(struct user_auth_info *auth_info) { char *label = NULL; - char *pass; + char pwd[256] = {0}; + int rc; TALLOC_CTX *frame; if (get_cmdline_auth_info_got_pass(auth_info) || @@ -258,9 +259,9 @@ void set_cmdline_auth_info_getpass(struct user_auth_info *auth_info) frame = talloc_stackframe(); label = talloc_asprintf(frame, "Enter %s's password: ", get_cmdline_auth_info_username(auth_info)); - pass = getpass(label); - if (pass) { - set_cmdline_auth_info_password(auth_info, pass); + rc = samba_getpass(label, pwd, sizeof(pwd), false, false); + if (rc == 0) { + set_cmdline_auth_info_password(auth_info, pwd); } TALLOC_FREE(frame); } -- 2.11.4.GIT