From 30d505e91bbf8e08d6f80314798e4e1a48ae43f9 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Tue, 12 Feb 2019 09:34:54 +1300 Subject: [PATCH] selftest: Only set clockskew to 5 seconds for MIT Kerberos This was added in ac5427c6eba09134411f76a5e6f7e2643fa74eed as part of the MIT KDC effort, but makes some tests much less reliable under high load. As the Heimdal build does not need this, only specify for the MIT build. Tested with an MIT AD DC build with: make test TESTS="samba3.raw.session samba3.smb2.session" Signed-off-by: Andrew Bartlett Reviewed-by: Gary Lockyer Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Wed Feb 13 05:49:43 CET 2019 on sn-devel-144 --- selftest/target/Samba.pm | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/selftest/target/Samba.pm b/selftest/target/Samba.pm index 3fe53f94a2c..d74a4438ba4 100644 --- a/selftest/target/Samba.pm +++ b/selftest/target/Samba.pm @@ -250,16 +250,22 @@ sub mk_krb5_conf($$) ticket_lifetime = 24h forwardable = yes allow_weak_crypto = yes - # Set the grace clocskew to 5 seconds - # This is especially required by samba3.raw.session krb5 and - # reauth tests - clockskew = 5 + # We are running on the same machine, do not correct # system clock differences kdc_timesync = 0 "; + if (defined($ENV{MITKRB5})) { + print KRB5CONF " + # Set the grace clocskew to 5 seconds + # This is especially required by samba3.raw.session krb5 and + # reauth tests when not using Heimdal + clockskew = 5 + "; + } + if (defined($ctx->{krb5_ccname})) { print KRB5CONF " default_ccache_name = $ctx->{krb5_ccname} -- 2.11.4.GIT