From 2a7454959e93e5bd11161707d0bd16a431b92351 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Fri, 1 Dec 2006 16:13:06 +0000 Subject: [PATCH] r19984: Must have been drunk yesterday. Freeing memctx is all we need, fix double free stupidity --- source/smbd/sesssetup.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/source/smbd/sesssetup.c b/source/smbd/sesssetup.c index 11c5e9bbf9b..0cf6692e228 100644 --- a/source/smbd/sesssetup.c +++ b/source/smbd/sesssetup.c @@ -302,8 +302,7 @@ static int reply_spnego_kerberos(connection_struct *conn, DEBUG(1, ("PAM account restriction prevents user login\n")); data_blob_free(&ap_rep); data_blob_free(&session_key); - talloc_destroy(mem_ctx); - TALLOC_FREE(pw); + TALLOC_FREE(mem_ctx); return ERROR_NT(nt_status_squash(ret)); } } @@ -327,7 +326,7 @@ static int reply_spnego_kerberos(connection_struct *conn, SAFE_FREE(client); data_blob_free(&ap_rep); data_blob_free(&session_key); - talloc_destroy(mem_ctx); + TALLOC_FREE(mem_ctx); return ERROR_NT(nt_status_squash(NT_STATUS_LOGON_FAILURE)); } } @@ -335,6 +334,8 @@ static int reply_spnego_kerberos(connection_struct *conn, /* setup the string used by %U */ sub_set_smb_name( real_username ); +C_FR +C_FREE reload_services(True); if ( map_domainuser_to_guest ) { @@ -352,7 +353,6 @@ static int reply_spnego_kerberos(connection_struct *conn, data_blob_free(&ap_rep); data_blob_free(&session_key); TALLOC_FREE(mem_ctx); - TALLOC_FREE(pw); return ERROR_NT(nt_status_squash(ret)); } @@ -366,7 +366,6 @@ static int reply_spnego_kerberos(connection_struct *conn, data_blob_free(&ap_rep); data_blob_free(&session_key); TALLOC_FREE(mem_ctx); - TALLOC_FREE(pw); return ERROR_NT(nt_status_squash(ret)); } @@ -390,7 +389,6 @@ static int reply_spnego_kerberos(connection_struct *conn, SAFE_FREE(client); data_blob_free(&ap_rep); data_blob_free(&session_key); - TALLOC_FREE(pw); TALLOC_FREE( mem_ctx ); TALLOC_FREE( server_info ); return ERROR_NT(nt_status_squash(ret)); @@ -435,7 +433,6 @@ static int reply_spnego_kerberos(connection_struct *conn, data_blob_free(&ap_rep_wrapped); data_blob_free(&response); TALLOC_FREE(mem_ctx); - TALLOC_FREE(pw); return -1; /* already replied */ } -- 2.11.4.GIT