From 202e2ab5e14fdd70b78dbbd48685e44f22b0d51d Mon Sep 17 00:00:00 2001 From: =?utf8?q?G=C3=BCnther=20Deschner?= Date: Wed, 3 May 2017 11:31:20 +0200 Subject: [PATCH] s3-rpcclient: Fix enumdata spoolss display of REG_DWORD One should not assume a REG_DWORD is always 4 byte long. In an enumdata(ex) context, the first reply will return with content in a buffer that can fill the largest entry in the array of attributes. All subsequent queries then reuse this buffer even if the key/value pair in question then is just a 4 byte DWORD. The remaining buffer will be just empty and of no interest. Signed-off-by: Guenther Deschner Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Sun May 7 03:28:21 CEST 2017 on sn-devel-144 --- source3/rpcclient/cmd_spoolss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/rpcclient/cmd_spoolss.c b/source3/rpcclient/cmd_spoolss.c index 00dc2e0e817..34cbb7e0cdb 100644 --- a/source3/rpcclient/cmd_spoolss.c +++ b/source3/rpcclient/cmd_spoolss.c @@ -770,7 +770,7 @@ static void display_reg_value(const char *name, enum winreg_Type type, DATA_BLOB switch(type) { case REG_DWORD: - if (blob.length == sizeof(uint32_t)) { + if (blob.length >= sizeof(uint32_t)) { printf("%s: REG_DWORD: 0x%08x\n", name, IVAL(blob.data,0)); } else { printf("%s: REG_DWORD: \n", name); -- 2.11.4.GIT