From 195ba5dd6b3757eb42f4a05ab488306053c6cf39 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 30 Mar 2011 06:57:05 +0200 Subject: [PATCH] s3: Fix Coverity ID 2236: REVERSE_INULL We have already dereferenced "b", and the other calls in this loop can only have worked with a valid handle (cherry picked from commit 8486f0fa0495e51d204dca970bf864041123b631) --- source3/smbd/lanman.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/source3/smbd/lanman.c b/source3/smbd/lanman.c index b6efaa114f8..1749eb01079 100644 --- a/source3/smbd/lanman.c +++ b/source3/smbd/lanman.c @@ -1145,9 +1145,7 @@ static bool api_DosPrintQEnum(struct smbd_server_connection *sconn, subcntarr[i] = num_jobs; subcnt += subcntarr[i]; - if (b && is_valid_policy_hnd(&handle)) { - dcerpc_spoolss_ClosePrinter(b, mem_ctx, &handle, &werr); - } + dcerpc_spoolss_ClosePrinter(b, mem_ctx, &handle, &werr); } if (init_package(&desc,queuecnt,subcnt)) { -- 2.11.4.GIT