From 161609d00958c3816ec1b6ad4b0eab7a213d6a9d Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Tue, 19 Nov 2002 01:46:14 +0000 Subject: [PATCH] Very curious. It turns out attribute matching on truncate only matters when opening truncate with current SYSTEM|HIDDEN -> NONE. It's fine to truncate on open with current NONE -> SYSTEM | HIDDEN. Jeremy. --- source/smbd/open.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/smbd/open.c b/source/smbd/open.c index 5e7400eb746..1958ff7c079 100644 --- a/source/smbd/open.c +++ b/source/smbd/open.c @@ -700,11 +700,11 @@ static BOOL open_match_attributes(connection_struct *conn, char *path, mode_t ex /* If we're mapping SYSTEM and HIDDEN ensure they match. */ if (lp_map_system(SNUM(conn))) { - if ((old_dos_mode & FILE_ATTRIBUTE_SYSTEM) != (new_dos_mode & FILE_ATTRIBUTE_SYSTEM)) + if ((old_dos_mode & FILE_ATTRIBUTE_SYSTEM) && !(new_dos_mode & FILE_ATTRIBUTE_SYSTEM)) return False; } if (lp_map_hidden(SNUM(conn))) { - if ((old_dos_mode & FILE_ATTRIBUTE_HIDDEN) != (new_dos_mode & FILE_ATTRIBUTE_HIDDEN)) + if ((old_dos_mode & FILE_ATTRIBUTE_HIDDEN) && !(new_dos_mode & FILE_ATTRIBUTE_HIDDEN)) return False; } return True; -- 2.11.4.GIT