s3: smbd: Only set xconn->smb1.negprot.done = true after supported_protocols[protocol...
commit8db0c1bff6f42feabd2e4d9dfb13ae12cc29607b
authorJeremy Allison <jra@samba.org>
Tue, 26 Nov 2019 20:53:09 +0000 (26 12:53 -0800)
committerJeremy Allison <jra@samba.org>
Wed, 4 Dec 2019 21:27:24 +0000 (4 21:27 +0000)
treec4f5249881168dbdee3d6af22bb4e4c060e2c68b
parent46899ecf836d350c0c29b615869851da7d0ad6fb
s3: smbd: Only set xconn->smb1.negprot.done = true after supported_protocols[protocol].proto_reply_fn() succeeds.

Otherwise we can end up with negprot.done set, but
without smbXsrv_connection_init_tables() being called.

This can cause a client self-crash.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Dec  4 21:27:24 UTC 2019 on sn-devel-184
selftest/knownfail.d/smb1_fuzz_smbd [deleted file]
source3/smbd/negprot.c