| commit | fff94aa436d4ae2707a9bff75aa27c404882067f | |
| author | Steven Danneman <steven.danneman@isilon.com> | |
| Sat, 30 Jan 2010 21:29:23 +0000 (30 13:29 -0800) | ||
| committer | Karolin Seeger <kseeger@samba.org> | |
| Mon, 15 Feb 2010 13:46:50 +0000 (15 14:46 +0100) | ||
| tree | cb244ef4760f593eab02324b1d75619a24d17329 | treesnapshot (tar.gz zip) |
| parent | b5c8ef81bd5178ceb68b492a1eeac911289edb82 | commitdiff |
s3/smbd: Fix string buffer overflow causing heap corruption
The destname malloc size was not taking into account the 1 extra byte
needed if a string without a leading '/' was passed in and that slash
was added.
This would cause the '\0' byte to be written past the end of the
malloced destname string and corrupt whatever heap memory was there.
This problem would be hit if a share name was given in smb.conf without
a leading '/' and if it was the exact size of the allocated STRDUP memory
which in some implementations of malloc is a power of 2.
(cherry picked from commit f42971c520360e69c4cdd64bebb02a5f5ba49b94)
Fix bug #7096.
(cherry picked from commit db5ccb70b6ac51ea263889cc9cdd523673ae8ecd)
(cherry picked from commit 3916710b9414d679774399e6d0cff61e4b67a2e3)
The destname malloc size was not taking into account the 1 extra byte
needed if a string without a leading '/' was passed in and that slash
was added.
This would cause the '\0' byte to be written past the end of the
malloced destname string and corrupt whatever heap memory was there.
This problem would be hit if a share name was given in smb.conf without
a leading '/' and if it was the exact size of the allocated STRDUP memory
which in some implementations of malloc is a power of 2.
(cherry picked from commit f42971c520360e69c4cdd64bebb02a5f5ba49b94)
Fix bug #7096.
(cherry picked from commit db5ccb70b6ac51ea263889cc9cdd523673ae8ecd)
(cherry picked from commit 3916710b9414d679774399e6d0cff61e4b67a2e3)
| source3/smbd/service.c | diffblobblamehistory |