| commit | fa25793ebff92bee2bb1bf0b437b5f705ee8a1dc | |
| author | Joseph Sutton <josephsutton@catalyst.net.nz> | |
| Mon, 30 Oct 2023 23:11:37 +0000 (31 12:11 +1300) | ||
| committer | Andrew Bartlett <abartlet@samba.org> | |
| Thu, 2 Nov 2023 03:08:37 +0000 (2 03:08 +0000) | ||
| tree | 18864378dbdc8e3c4c3030f214b53724b07a86b9 | treesnapshot (tar.gz zip) |
| parent | c095ec02ff1a13bed5503a460eb6a8a39f03ade3 | commitdiff |
s4:rpc_server: Properly initialize ‘lsa_CreateTrustedDomainEx2’ structure (CID 1499407)
dcesrv_lsa_CreateTrustedDomain_base() invokes DCESRV_PULL_HANDLE(),
which invokes DCESRV_PULL_HANDLE_RETVAL(), which invokes
DCESRV_CHECK_HANDLE(), which might invoke DCESRV_FAULT(), which accesses
r2.out.result, which is uninitialized — invoking undefined behaviour.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
dcesrv_lsa_CreateTrustedDomain_base() invokes DCESRV_PULL_HANDLE(),
which invokes DCESRV_PULL_HANDLE_RETVAL(), which invokes
DCESRV_CHECK_HANDLE(), which might invoke DCESRV_FAULT(), which accesses
r2.out.result, which is uninitialized — invoking undefined behaviour.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
| source4/rpc_server/lsa/dcesrv_lsa.c | diffblobblamehistory |