lib: canonicalize pull_dos_date3()
commitf2af647e7dd9fce537ce1c82e965486eee79aa27
authorRalph Boehme <slow@samba.org>
Fri, 29 Nov 2019 08:43:21 +0000 (29 08:43 +0000)
committerJeremy Allison <jra@samba.org>
Fri, 6 Dec 2019 00:17:36 +0000 (6 00:17 +0000)
tree5fca19f5b398ada3eabf9bb53ebed722307e0031
parent7a69f642d7b138255a73ef42ab6dd9a5e50e5309
lib: canonicalize pull_dos_date3()

Returns 0xFFFFFFFF as (time_t)-1. This avoids misenterpreting 0xFFFFFFFF as a
valid time_t value (0xFFFFFFFF = Sun 07 Feb 2106 06:28:15 AM GMT) on 64-bit
platforms where time_t is 64-bit.

Currently direct and indirect callers of pull_dos_date3() rely on the fact that
the resulting time_t is checked with null_time() which also checks for
0xFFFFFFFF as sentinel value amongst 0 and -1:

        return t == 0 ||
                t == (time_t)0xFFFFFFFF ||
                t == (time_t)-1;

By returning -1 instead of 0xFFFFFFFF, callers can safely pass the result to
unix_to_nt_time() which *doesn't* check for 0xFFFFFFFF, only -1.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
lib/util/time.c