s4: libcli/finddcs_cldap: continue processing CLDAP until all addresses are used
commiteb029b32e95c9e7382488f3a1b033cdbe3237c1c
authorAlexander Bokovoy <ab@samba.org>
Wed, 20 May 2015 08:17:38 +0000 (20 11:17 +0300)
committerStefan Metzmacher <metze@samba.org>
Wed, 20 May 2015 17:29:30 +0000 (20 19:29 +0200)
treed50187889d7aaa52a584e183149a25c383b2475b
parent47a3f9cc5a1e3de5b7eadeae5c001863c2adca2b
s4: libcli/finddcs_cldap: continue processing CLDAP until all addresses are used

This is a subtle bug that causes CLDAP pings to fail if SRV records
discovered cannot be resolved or connection to them cannot be
established. The code that fires up CLDAP ping will silently cancel
the whole tevent request without going to the next server in the queue.

This may happen, for example, when connection to IPv6 addresses couldn't
be established, or when IPv4 address is not online or blocked by
firewall.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11284

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source4/libcli/finddcs_cldap.c