| commit | e401ae44b2f952fc2686065fbfb3a563e3d4066a | |
| author | Noel Power <noel.power@suse.com> | |
| Fri, 14 Jul 2023 13:53:29 +0000 (14 14:53 +0100) | ||
| committer | Andrew Bartlett <abartlet@samba.org> | |
| Fri, 21 Jul 2023 01:25:37 +0000 (21 01:25 +0000) | ||
| tree | 61534d3ee1114937ecf798f0e58e23bf3575bdb3 | treesnapshot (tar.gz zip) |
| parent | 5e473cba0d3dd842a41789f5d61d8234db54d6b7 | commitdiff |
python/samba: Adjust tarfile extraction filter
The 'data_filter' is far too restrictive, this filter doesn't apply any
mode bits to directories which in turn will result in unexpected
directory permissions of the amongst others msg.[ls]ock directories.
With 'data_filter' and a 'patched' python at best we experience
CI failures with samba-ad-back1 & samba-ad-back2 CI jobs due to server
startup failures, at worst user/admins will need to adjust directory
permissions post backup.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15390
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
The 'data_filter' is far too restrictive, this filter doesn't apply any
mode bits to directories which in turn will result in unexpected
directory permissions of the amongst others msg.[ls]ock directories.
With 'data_filter' and a 'patched' python at best we experience
CI failures with samba-ad-back1 & samba-ad-back2 CI jobs due to server
startup failures, at worst user/admins will need to adjust directory
permissions post backup.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15390
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
| python/samba/safe_tarfile.py | diffblobblamehistory |