| commit | e311801e0e7171a2b50e39d3e0c2d2137f8b3d7e | |
| author | Ralph Boehme <slow@samba.org> | |
| Tue, 3 Jul 2018 13:30:33 +0000 (3 15:30 +0200) | ||
| committer | Ralph Boehme <slow@samba.org> | |
| Wed, 4 Jul 2018 19:07:09 +0000 (4 21:07 +0200) | ||
| tree | fc265a5b0cad2a02d57ee3a26734d85555b655a3 | treesnapshot (tar.gz zip) |
| parent | a958dc35bbeea61fa1344a10602e7d40c8339764 | commitdiff |
lib: smb_threads: fix access before init bug
talloc_stackframe_internal() calls SMB_THREAD_GET_TLS(global_ts) which
calls smb_get_tls_pthread() in the POSIX pthread wrapper implementation.
If SMB_THREAD_SET_TLS() hasn't been called before, global_ts is NULL and
smb_get_tls_pthread dereferences it so it crashes.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13505
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
talloc_stackframe_internal() calls SMB_THREAD_GET_TLS(global_ts) which
calls smb_get_tls_pthread() in the POSIX pthread wrapper implementation.
If SMB_THREAD_SET_TLS() hasn't been called before, global_ts is NULL and
smb_get_tls_pthread dereferences it so it crashes.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13505
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
| lib/util/smb_threads.h | diffblobblamehistory |