CVE-2018-10919 tests: Add test case for object visibility with limited rights
commite2574d092dc91ee1ba7ee04938c63b3ee811c5af
authorTim Beale <timbeale@catalyst.net.nz>
Tue, 24 Jul 2018 22:08:34 +0000 (25 10:08 +1200)
committerStefan Metzmacher <metze@samba.org>
Tue, 14 Aug 2018 15:42:12 +0000 (14 17:42 +0200)
tree539c0376c4ee146b81a4040dad5f7128801e96b4
parent10a2c8da54adc85a9d567e8b805a2cce16893d9e
CVE-2018-10919 tests: Add test case for object visibility with limited rights

Currently Samba is a bit disclosive with LDB_OP_PRESENT (i.e.
attribute=*) searches compared to Windows.

All the acl.py tests are based on objectClass=* searches, where Windows
will happily tell a user about objects they have List Contents rights,
but not Read Property rights for. However, if you change the attribute
being searched for, suddenly the objects are no longer visible on
Windows (whereas they are on Samba).

This is a problem, because Samba can tell you about which objects have
confidential attributes, which in itself could be disclosive.

This patch adds a acl.py test-case that highlights this behaviour. The
test passes against Windows but fails against Samba.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
selftest/knownfail.d/acl [new file with mode: 0644]
source4/dsdb/tests/python/acl.py