| commit | e1bf108ae965ae730c67524164fa36497ea905b5 | |
| author | Jeremy Allison <jra@samba.org> | |
| Sun, 19 Sep 2004 01:16:45 +0000 (19 01:16 +0000) | ||
| committer | Gerald (Jerry) Carter <jerry@samba.org> | |
| Wed, 10 Oct 2007 15:52:42 +0000 (10 10:52 -0500) | ||
| tree | a8bacccc7e0c3e1579f9422c66317b8543c2108f | treesnapshot (tar.gz zip) |
| parent | cd910ffc510f2007c2619d7a4d31e5e41de7d1d1 | commitdiff |
r2413: Arggg. Stupid, stupid, stupid me ! I added a paranoia test
case when I was developing the deferred open case and made it
too tight. It will fire (incorrectly) and panic when a client
does a second open for a file with a different mid (multiplex-id)
request. Doh ! This is a perfectly valid thing for a client to
do (have two pending opens with different mids outstanding on
the same file) and currently when the first pending open expires
with a share violation the paranoia code will panic smbd.
It's a rare condition, but obvious now I've looked at the
code.
Fix for bug #1743.
Jeremy.
case when I was developing the deferred open case and made it
too tight. It will fire (incorrectly) and panic when a client
does a second open for a file with a different mid (multiplex-id)
request. Doh ! This is a perfectly valid thing for a client to
do (have two pending opens with different mids outstanding on
the same file) and currently when the first pending open expires
with a share violation the paranoia code will panic smbd.
It's a rare condition, but obvious now I've looked at the
code.
Fix for bug #1743.
Jeremy.
| source/locking/locking.c | diffblobblamehistory |