| commit | db37043bc5c67e536bcaaf1941cb12ec2e72efc9 | |
| author | Martin Schwenke <martin@meltin.net> | |
| Fri, 27 May 2022 13:23:48 +0000 (27 23:23 +1000) | ||
| committer | Amitay Isaacs <amitay@samba.org> | |
| Fri, 22 Jul 2022 16:09:31 +0000 (22 16:09 +0000) | ||
| tree | e61914f3cdf82eabd53d5ab81e234ff377702013 | treesnapshot (tar.gz zip) |
| parent | 00f1d6d94764ba1312500c72fd08e7df3fae064b | commitdiff |
ctdb-scripts: Avoid ShellCheck warning SC2295
For example:
In /home/martins/samba/samba/ctdb/tools/onnode line 304:
[ "$nodes" != "${nodes%[ ${nl}]*}" ] && verbose=true
^---^ SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns.
Did you mean:
[ "$nodes" != "${nodes%[ "${nl}"]*}" ] && verbose=true
For more information:
https://www.shellcheck.net/wiki/SC2295 -- Expansions inside ${..} need to b...
Who knew? Thanks ShellCheck!
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
For example:
In /home/martins/samba/samba/ctdb/tools/onnode line 304:
[ "$nodes" != "${nodes%[ ${nl}]*}" ] && verbose=true
^---^ SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns.
Did you mean:
[ "$nodes" != "${nodes%[ "${nl}"]*}" ] && verbose=true
For more information:
https://www.shellcheck.net/wiki/SC2295 -- Expansions inside ${..} need to b...
Who knew? Thanks ShellCheck!
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>