| commit | d5750f016362ce55a1c905509c419756b523dde6 | |
| author | Andrew Bartlett <abartlet@samba.org> | |
| Tue, 1 Aug 2017 01:18:33 +0000 (1 13:18 +1200) | ||
| committer | Andrew Bartlett <abartlet@samba.org> | |
| Tue, 1 Aug 2017 05:52:38 +0000 (1 07:52 +0200) | ||
| tree | 94d79425469c4d1f7fed6b5dece1763ef5d7af43 | treesnapshot (tar.gz zip) |
| parent | 5b316a4c7aa830194bf254942daa5aef88a0ed17 | commitdiff |
dsdb: Fix dsdb_next_callback to correctly use ldb_module_done() etc
If we do not call ldb_module_done() then we do not know that up_req->callback()
has been called, and ldb_next_request() will call the callback again.
If called twice, the new ldb_lock_backend_callback() in ldb 1.2.0 will segfault.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12904
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Aug 1 07:52:38 CEST 2017 on sn-devel-144
If we do not call ldb_module_done() then we do not know that up_req->callback()
has been called, and ldb_next_request() will call the callback again.
If called twice, the new ldb_lock_backend_callback() in ldb 1.2.0 will segfault.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12904
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Aug 1 07:52:38 CEST 2017 on sn-devel-144
| python/samba/tests/dsdb.py | diffblobblamehistory | |
| source4/dsdb/pydsdb.c | diffblobblamehistory | |
| source4/dsdb/samdb/ldb_modules/util.c | diffblobblamehistory | |
| source4/dsdb/samdb/samdb.h | diffblobblamehistory |