s4.2/fsmo.py: fixed fsmo transfer exception
commitceb7c090d8f11dc320326ac02cf3dabb1ce121e7
authorSteve Howells <steve.howells@moscowfirst.com>
Sat, 31 Jan 2015 16:09:17 +0000 (31 16:09 +0000)
committerKarolin Seeger <kseeger@samba.org>
Sat, 6 Jun 2015 22:06:59 +0000 (7 00:06 +0200)
treee63fa97a35b05a3923ddbe806f70a23e3ebaab8f
parent42330654d1692f848556c1146a8644b8639a6816
s4.2/fsmo.py: fixed fsmo transfer exception

In transfer_role() there is an duplicate call to samdb.modify() inside the if statement
where the type of role is being determined (specifically for the naming fsmo). This
call is unnecessary as after the if statement their is a correct call, with a try/catch
block, used by all fsmo transfers that will handle errors - such as the DC with the
fsmo role being offline.

The call to samdb.modify() inside the if statement for naming fsmo has been removed.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10924

Signed-off-by: Steve Howells <steve.howells@moscowfirst.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Marc Muehlfeld <mmuehlfeld@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 9198246f91c02e33ed7a3580588557d0fb9f8811)
python/samba/netcmd/fsmo.py