s3:auth: make use of make_{server,session}_info_anonymous()
commitcbbb6ef5c2b41bb46972fabc08c55134098ac29b
authorStefan Metzmacher <metze@samba.org>
Fri, 2 Mar 2018 13:40:19 +0000 (2 14:40 +0100)
committerStefan Metzmacher <metze@samba.org>
Wed, 21 Mar 2018 01:29:57 +0000 (21 02:29 +0100)
treeb8cc852aeb249ebe644cd2f2e5bc8a9d99bcc1cb
parentf9d850d3d1b803143bee807ebba218b7f14aaef0
s3:auth: make use of make_{server,session}_info_anonymous()

It's important to have them separated from make_{server,session}_info_guest(),
because there's a fundamental difference between anonymous (the client requested
no authentication) and guest (the server lies about the authentication failure).

When it's really an anonymous connection, we should reflect that in the
resulting session info.

This should fix a problem where Windows 10 tries to join
a Samba hosted NT4 domain and has SMB2/3 enabled.

We no longer return SMB_SETUP_GUEST or SMB2_SESSION_FLAG_IS_GUEST
for true anonymous connections.

The commit message from a few commit before shows the resulting
auth_session_info change.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13328

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Mar 16 03:03:31 CET 2018 on sn-devel-144

(cherry picked from commit 1957bf11f127fc08c6622999cadc7dd580ac7d3b)

Autobuild-User(v4-8-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-8-test): Wed Mar 21 02:29:57 CET 2018 on sn-devel-144
selftest/knownfail.d/anonymous-guest [deleted file]
source3/auth/auth_builtin.c
source3/auth/auth_ntlmssp.c