pyldb: Make ldb.Message containment testing consistent with indexing
commitc532b425e739a5a6860e37fd616dc5293cea0f37
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Sat, 25 Sep 2021 02:39:59 +0000 (25 14:39 +1200)
committerStefan Metzmacher <metze@samba.org>
Thu, 28 Oct 2021 08:58:16 +0000 (28 08:58 +0000)
tree44d216018a0844cae932bc8f9286a79810d055d0
parent64c41d30986a34b3311bc03ffce9a8856c7f4f18
pyldb: Make ldb.Message containment testing consistent with indexing

Previously, containment testing using the 'in' operator was handled by
performing an equality comparison between the chosen object and each of
the message's keys in turn. This behaviour was prone to errors due to
not considering differences in case between otherwise equal elements, as
the indexing operations do.

Containment testing should now be more consistent with the indexing
operations and with the get() method of ldb.Message.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14845
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14848

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 860d8902a9c502d4be83396598cf4a53c80fea69)
lib/ldb/pyldb.c
selftest/knownfail.d/pyldb [deleted file]