nmblib: avoid undefined behaviour in handle_name_ptrs()
commitaff55431702035a8d4d8c0bc8e88cf1ba726e105
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Sun, 19 Jan 2020 02:08:58 +0000 (19 15:08 +1300)
committerKarolin Seeger <kseeger@samba.org>
Wed, 18 Mar 2020 14:15:45 +0000 (18 14:15 +0000)
tree278ae142d60532fa74fff6c4c86adb384d920246
parent14511bd7ccd655e6da4c0904512d8d1440b7e9ba
nmblib: avoid undefined behaviour in handle_name_ptrs()

If *offset is length - 1, we would read ubuf[(*offset)+1] as the lower
bits of the new *offset. This value is undefined, but because it is
checked against the valid range, there is no way to read further
beyond that one byte.

Credit to oss-fuzz.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14242
OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20193

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Feb  7 10:19:39 UTC 2020 on sn-devel-184

(cherry picked from commit 3bc7acc62646b105b03fd3c65e9170a373f95392)

Autobuild-User(v4-11-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-11-test): Wed Mar 18 14:15:45 UTC 2020 on sn-devel-184
source3/libsmb/nmblib.c