| commit | a9dab567e882a6ffd376c5f39112cf00866c2d63 | |
| author | David Disseldorp <ddiss@samba.org> | |
| Thu, 4 Dec 2014 19:03:39 +0000 (4 20:03 +0100) | ||
| committer | Karolin Seeger <kseeger@samba.org> | |
| Wed, 14 Jan 2015 20:58:09 +0000 (14 21:58 +0100) | ||
| tree | 0fa0f53260b05c1eb3ee11ff667ec3bf30c81643 | treesnapshot (tar.gz zip) |
| parent | c5cff323b43d9c9785cce4495921dc755da8991a | commitdiff |
spoolss: clear JobInfo on GetJob error
In handling a spoolss GetJob request, the _spoolss_GetJob() handler may
return an immediate error if one of the input parameters is invalid. If
this is done without zeroing the pre-allocated @info pointer, then
api_spoolss_GetJob() will attempt to marshall @info, which in the case
of an @offered value of zero results in a marshalling error:
ndr_push_error(7): Bad subcontext (PUSH) content_size 64 is larger
than size_is(0)
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10984
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 89869e090c56a3f83b451b437f9c3f40a231dd24)
In handling a spoolss GetJob request, the _spoolss_GetJob() handler may
return an immediate error if one of the input parameters is invalid. If
this is done without zeroing the pre-allocated @info pointer, then
api_spoolss_GetJob() will attempt to marshall @info, which in the case
of an @offered value of zero results in a marshalling error:
ndr_push_error(7): Bad subcontext (PUSH) content_size 64 is larger
than size_is(0)
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10984
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 89869e090c56a3f83b451b437f9c3f40a231dd24)
| source3/rpc_server/spoolss/srv_spoolss_nt.c | diffblobblamehistory |