lib: strings: Fix the behavior of strcasecmp_m_handle() in the face of bad conversions.
commita8cbd5a9997920b267e94a3070aef0afa94aa8bf
authorJeremy Allison <jra@samba.org>
Sat, 2 Aug 2014 04:29:21 +0000 (1 21:29 -0700)
committerKarolin Seeger <kseeger@samba.org>
Mon, 1 Sep 2014 19:34:11 +0000 (1 21:34 +0200)
tree221b06d6fb1fa0969a10b08bc4f5ef73c77d3257
parent5df60b233e7d66da662ba4ccea6b28cd0cae85ec
lib: strings: Fix the behavior of strcasecmp_m_handle() in the face of bad conversions.

When either string has a bad conversion, we fall back to
doing raw ascii byte comparisons using strcasecmp().

The problem is we've already stepped past the character
that failed the conversion, so we're not re-testing those
characters for comparison. This can have the effect of
causing strcasecmp_m_handle() to report that two strings
are identical when they are not, if the failed conversion
takes place at the end of the string.

The correct behavior is to step back to the point of
the string(s) that failed the conversion, and continue
the test from there.

Found by <lev@zadarastorage.com> when investigating bug
10716 - smbd constantly crashes when filename contains non-ascii character.

Given the normal character set of utf-8, and an on
disk filename of ISO-8859-1 of file-é on disk hex
value: 66 69 6c 65 2d e9, an incoming open given the
correct utf8 name of file-é will collide when it
should not.

Fixes:

Bug 10716 - smbd constantly crashes when filename contains non-ascii character

https://bugzilla.samba.org/show_bug.cgi?id=10716

Signed-off-by: Jeremy Allison <jra@samba.org>
lib/util/charset/util_str.c