| commit | a0cfc381d358e9a4ae758c1598818e43094347da | |
| author | Amitay Isaacs <amitay@gmail.com> | |
| Thu, 23 May 2013 03:04:06 +0000 (23 13:04 +1000) | ||
| committer | Amitay Isaacs <amitay@gmail.com> | |
| Thu, 23 May 2013 06:19:20 +0000 (23 16:19 +1000) | ||
| tree | d9342b90718697221944a009cc09499debb50e6c | treesnapshot (tar.gz zip) |
| parent | 7ee9e22a09e73d218325c453a36e56f6092c7397 | commitdiff |
tools/ctdb: Fix racy ipreallocate code
This code tried to find the recovery master and send an ipreallocate
request to that node. When a node is stopped, this code asked the
stopped node for recovery master. Stopped node does not have up-to-date
information on the current recovery master. So ipreallocate requests
were sent to the wrong node and ignored by that node which is not the
recovery master.
Send ipreallocate request to all active nodes. That way we guarantee
that the current recovery master will see it and respond to it.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Pair-Programmed-With: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 0577ce3c68e4febf49a1ef5093e918db9d5ec636)
This code tried to find the recovery master and send an ipreallocate
request to that node. When a node is stopped, this code asked the
stopped node for recovery master. Stopped node does not have up-to-date
information on the current recovery master. So ipreallocate requests
were sent to the wrong node and ignored by that node which is not the
recovery master.
Send ipreallocate request to all active nodes. That way we guarantee
that the current recovery master will see it and respond to it.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Pair-Programmed-With: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 0577ce3c68e4febf49a1ef5093e918db9d5ec636)
| ctdb/tools/ctdb.c | diffblobblamehistory |