| commit | 8e70f0c174a9c95c221ab148ab30a06e0afa4de5 | |
| author | Joseph Sutton <josephsutton@catalyst.net.nz> | |
| Mon, 3 May 2021 03:48:43 +0000 (3 15:48 +1200) | ||
| committer | Jule Anger <janger@samba.org> | |
| Thu, 16 Sep 2021 08:07:11 +0000 (16 08:07 +0000) | ||
| tree | 05b6b1e1a61f5e676a95035d946be13f8257bbc8 | treesnapshot (tar.gz zip) |
| parent | c40a90d7c7afdfdba86e8941caa52fb2bb4f7ff9 | commitdiff |
Revert "libsmb: Use sid_parse()"
This reverts commit afd5d34f5e1d13ba88448b3b94d353aa8361d1a9.
This code originally used ndr_pull_struct_blob() to pull one SID from a
buffer potentially containing multiple SIDs. When this was changed to
use sid_parse(), it was now attempting to parse the whole buffer as a
single SID with ndr_pull_struct_blob_all(), which would cause it to fail
if more than one SID was present.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14817
(cherry picked from commit 2b487890d946df88abce67c3d07d74559f70f069)
This reverts commit afd5d34f5e1d13ba88448b3b94d353aa8361d1a9.
This code originally used ndr_pull_struct_blob() to pull one SID from a
buffer potentially containing multiple SIDs. When this was changed to
use sid_parse(), it was now attempting to parse the whole buffer as a
single SID with ndr_pull_struct_blob_all(), which would cause it to fail
if more than one SID was present.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14817
(cherry picked from commit 2b487890d946df88abce67c3d07d74559f70f069)
| source3/libsmb/clifsinfo.c | diffblobblamehistory |