CVE-2023-0225 s4-acl: Don't return early if dNSHostName element has no values
commit888c6ae8177d87e408722f67cc03359ae2533402
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Sun, 8 Jan 2023 22:22:34 +0000 (9 11:22 +1300)
committerJule Anger <janger@samba.org>
Mon, 20 Mar 2023 09:04:29 +0000 (20 10:04 +0100)
tree2890e0084ef8107e0ff7400ab998e91dfd2a0c8a
parent54691236fc80a932f2069eef0aa21d6818445503
CVE-2023-0225 s4-acl: Don't return early if dNSHostName element has no values

This early return would mistakenly allow an unprivileged user to delete
the dNSHostName attribute by making an LDAP modify request with no
values. We should no longer allow this.

Add or replace operations with no values and no privileges are
disallowed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15276

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
selftest/knownfail.d/dns-host-name-deletion [deleted file]
source4/dsdb/samdb/ldb_modules/acl.c