s3: libsmbclient: Fix cli_splice() fallback when reading less than a complete file.
commit80c7e284afadec4dc346248b1242b771b050f7da
authorJeremy Allison <jra@samba.org>
Thu, 12 Jul 2018 19:18:50 +0000 (12 12:18 -0700)
committerKarolin Seeger <kseeger@samba.org>
Sat, 28 Jul 2018 04:16:15 +0000 (28 06:16 +0200)
treec327b712fe0b29aa72bc046daff04a953d58fde3
parenta7783f5e470d6ca7d4659ba37eb558b6cc06b8a0
s3: libsmbclient: Fix cli_splice() fallback when reading less than a complete file.

We were always asking for SPLICE_BLOCK_SIZE even when the
remaining bytes we wanted were smaller than that. This works
when using cli_splice() on a complete file, as the cli_read()
terminated the read at the right place. We always have the
space to read SPLICE_BLOCK_SIZE bytes so this isn't an overflow.

Found by Bailey Berro <baileyberro@google.com>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13527

Signed-off-by: Bailey Berro <baileyberro@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Jul 13 14:57:14 CEST 2018 on sn-devel-144

(cherry picked from commit c9656fd2977557ab20ec4e3d87c385a9b2f1bf43)
selftest/knownfail
source3/libsmb/clireadwrite.c