dbcheck: Abandon dbcheck if we get an error during a transaction
commit7aaf3f5868e859e2a42222b29a06ab1deae52b70
authorAndrew Bartlett <abartlet@samba.org>
Fri, 26 Aug 2016 03:53:19 +0000 (26 15:53 +1200)
committerKarolin Seeger <kseeger@samba.org>
Tue, 13 Sep 2016 10:27:26 +0000 (13 12:27 +0200)
tree4bcc36329cf1eb4684069aa4756e991ec96195c2
parent3f199828e132a852f27a90a4bbcb50a4d6f61d9f
dbcheck: Abandon dbcheck if we get an error during a transaction

Otherwise, anything that the transaction has already done to the DB will be left in the DB
even despite the failure.  For example, if a fix wrote to the DB, but then failed a post-write
check, then the fix will not be unrolled.

This is because we do not have nested transactions in TDB.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12178

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Aug 29 12:46:21 CEST 2016 on sn-devel-144

(cherry picked from commit db32a0e5ea8f652857e45480cc31ecb1ef884c1a)
python/samba/dbchecker.py
testprogs/blackbox/dbcheck-oldrelease.sh