| commit | 5b5546b28a401d7cc77402455b62ea5f69753499 | |
| author | Jeremy Allison <jra@samba.org> | |
| Fri, 5 Dec 2014 23:31:19 +0000 (5 15:31 -0800) | ||
| committer | Karolin Seeger <kseeger@samba.org> | |
| Mon, 8 Dec 2014 09:16:13 +0000 (8 10:16 +0100) | ||
| tree | bb413448d9a0cbbddf633fb0c8ae71a994933698 | treesnapshot (tar.gz zip) |
| parent | 8999acabfc3aaf9fcfecb4e71a2af96c74021a8d | commitdiff |
s3: smbd: Fix *allocate* calls to follow POSIX error return convention.
vfswrap_fallocate() is broken in that it can call posix_fallocate()
which returns an int error (and doesn't set errno) but can also
call Linux fallocate() which returns -1 and sets errno.
Standardize on the -1,errno convention.
Reported by Jones <jones.kstw@gmail.com> who provided the
initial patch. This patch tested and confirmed working
by him as well.
https://bugzilla.samba.org/show_bug.cgi?id=10982
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@suse.de>
(cherry picked from commit c9235deee0fc49c99cfaf2329b7af526d9dd12d0)
vfswrap_fallocate() is broken in that it can call posix_fallocate()
which returns an int error (and doesn't set errno) but can also
call Linux fallocate() which returns -1 and sets errno.
Standardize on the -1,errno convention.
Reported by Jones <jones.kstw@gmail.com> who provided the
initial patch. This patch tested and confirmed working
by him as well.
https://bugzilla.samba.org/show_bug.cgi?id=10982
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@suse.de>
(cherry picked from commit c9235deee0fc49c99cfaf2329b7af526d9dd12d0)
| source3/modules/vfs_default.c | diffblobblamehistory |