mount.cifs: don't leak passwords with verbose option
commit54de6ac85eb81aecc8b44a500f374edb95bf6a3d
authorJeff Layton <jlayton@redhat.com>
Fri, 25 Sep 2009 11:07:40 +0000 (25 07:07 -0400)
committerKarolin Seeger <kseeger@samba.org>
Thu, 1 Oct 2009 12:30:59 +0000 (1 14:30 +0200)
treeef85cf9d5283f48a0b3fb103cac9026f4d04accd
parent0293057abd8cdfc7c690cf5c8dd20b8a626d52ca
mount.cifs: don't leak passwords with verbose option

When running mount.cifs with the --verbose option, it'll print out the
option string that it passes to the kernel...including the mount
password if there is one. Print a placeholder string instead to help
ensure that this info can't be used for nefarious purposes.

Also, the --verbose option printed the option string before it was
completely assembled anyway. This patch should also make sure that
the complete option string is printed out.

Finally, strndup passwords passed in on the command line to ensure that
they aren't shown by --verbose as well. Passwords used this way can
never be truly kept private from other users on the machine of course,
but it's simple enough to do it this way for completeness sake.

Reported-by: Ronald Volgers <r.c.volgers@student.utwente.nl>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
client/mount.cifs.c