| commit | 47841952936e28916a738105194d662207477285 | |
| author | Jeremy Allison <jra@samba.org> | |
| Wed, 20 Oct 2010 20:58:15 +0000 (20 13:58 -0700) | ||
| committer | Karolin Seeger <kseeger@samba.org> | |
| Thu, 11 Nov 2010 11:12:31 +0000 (11 12:12 +0100) | ||
| tree | 2f2ce35281e9b95a42e833d84a70e9376496ccb0 | treesnapshot (tar.gz zip) |
| parent | 6e9d95f753b2b127268f1eb9a40d601002484bd1 | commitdiff |
Fix bug #7744 - "dfree cache time" doesn't work.
There is a bug in processing the dfree cache time, which is associated with the
smbd idle timer. The idle timer call conn_idle_all(), which updates the
conn->lastused timestamp. The dfree cache time code in smbd/dfree.c depends on
conn->lastused being up to date to refresh the cached dfree value.
Unfortunately the conn_idle_all() returns early if any of the connection
structs is not idle, never updating any further conn->lastused timestamps. If
(as is common due to an IPC$ connection) there are more than one used
connection struct, then the conn->lastused timestamps after the IPC$ connection
in the connection list will never be updated.
Ensure we always update conn->lastused for all connections when calling
conn_idle_all().
Jeremy.
There is a bug in processing the dfree cache time, which is associated with the
smbd idle timer. The idle timer call conn_idle_all(), which updates the
conn->lastused timestamp. The dfree cache time code in smbd/dfree.c depends on
conn->lastused being up to date to refresh the cached dfree value.
Unfortunately the conn_idle_all() returns early if any of the connection
structs is not idle, never updating any further conn->lastused timestamps. If
(as is common due to an IPC$ connection) there are more than one used
connection struct, then the conn->lastused timestamps after the IPC$ connection
in the connection list will never be updated.
Ensure we always update conn->lastused for all connections when calling
conn_idle_all().
Jeremy.
| source3/smbd/conn.c | diffblobblamehistory |