ctdb-daemon: Schedule running of callback if there are no event scripts
commit41ca635abb14ee3fd881978d1559c284e2e4737a
authorMartin Schwenke <martin@meltin.net>
Fri, 26 Aug 2016 06:29:47 +0000 (26 16:29 +1000)
committerStefan Metzmacher <metze@samba.org>
Tue, 6 Sep 2016 06:22:17 +0000 (6 08:22 +0200)
treee0b6454c5e1f1eac02c2328a28d750c42dbe3ff6
parent0ccfa212e431238b6ca1623d4280041872d5126d
ctdb-daemon: Schedule running of callback if there are no event scripts

The callback should never be called before an immediate return.  The
callback might reply to a control and the caller of
ctdb_event_script_callback_v() may not have assigned/stolen the
pointer to control structure into the private data.  Therefore,
calling the callback can dereference an uninitialised pointer to the
control structure when attempting to reply.

ctdb_event_script_callback_v() must succeed when there are no event
scripts.  On success the caller will mark the call as asynchronous and
expect the callback to be called.  Given that it can't be called
before return then it needs to be scheduled.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12180

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit 9076c44f35bf309b9e183bae98829f7154b93f33)
ctdb/server/eventscript.c