| commit | 39686f45056d942de5ebe3263a533a99ca17c79e | |
| author | Martin Schwenke <martin@meltin.net> | |
| Mon, 16 Feb 2015 03:04:09 +0000 (16 14:04 +1100) | ||
| committer | Amitay Isaacs <amitay@samba.org> | |
| Wed, 18 Feb 2015 04:34:06 +0000 (18 05:34 +0100) | ||
| tree | 5c4ec9f7259c2b81d870fc4b823512572934fd83 | treesnapshot (tar.gz zip) |
| parent | 664d62b61108657d3011cf0bcbe260533c97676f | commitdiff |
ctdb-scripts: Fix tunable setup code by making it shell-agnostic
All tunables set in configuration are currently set to 0 on system
where /bin/sh is dash (and perhaps other non-bash shells). dash puts
single quotes around all values in the output of the "set" builtin
command, whereas bash only puts them around values when something
needs to be quoted. Tunables always have a simple integer value so
dash will quote them and bash won't. The setup code currently passes
the raw value, including any quotes to "ctdb setvar ...". This
command does no error checking on the input, so "'1'" is converted to
0.
Change the code so that the value is determined from the shell
variable and is independent of the "set" output.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
All tunables set in configuration are currently set to 0 on system
where /bin/sh is dash (and perhaps other non-bash shells). dash puts
single quotes around all values in the output of the "set" builtin
command, whereas bash only puts them around values when something
needs to be quoted. Tunables always have a simple integer value so
dash will quote them and bash won't. The setup code currently passes
the raw value, including any quotes to "ctdb setvar ...". This
command does no error checking on the input, so "'1'" is converted to
0.
Change the code so that the value is determined from the shell
variable and is independent of the "set" output.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
| ctdb/config/events.d/00.ctdb | diffblobblamehistory |