| commit | 1addb4d44032d9737bf829cebdf8b4b8998a6b44 | |
| author | Michael Adam <obnox@samba.org> | |
| Thu, 27 Mar 2008 09:09:24 +0000 (27 10:09 +0100) | ||
| committer | Karolin Seeger <kseeger@samba.org> | |
| Thu, 10 Apr 2008 14:17:59 +0000 (10 16:17 +0200) | ||
| tree | 11ec8dbc0c28f4eb4f4926835cb9aacdbbf995c4 | treesnapshot (tar.gz zip) |
| parent | 9c48ccb25eb7eb564ce18ea1bda51861488a7538 | commitdiff |
posix_acls: clarify loop condition code, removing unneeded counter variable.
Coverity ID 545 falsely classified this as a NULL dereferencing bug.
By putting the loop of walking the list of aces more naturely not using
additional counters, it becomes much more obvious that it is not entered
when dir_ace == NULL.
The same modifications are done for the file_ace loop.
Michael
(cherry picked from commit 6dab6cf0647d7db01e5e472f8b5cf21395b7dbf0)
Coverity ID 545 falsely classified this as a NULL dereferencing bug.
By putting the loop of walking the list of aces more naturely not using
additional counters, it becomes much more obvious that it is not entered
when dir_ace == NULL.
The same modifications are done for the file_ace loop.
Michael
(cherry picked from commit 6dab6cf0647d7db01e5e472f8b5cf21395b7dbf0)
| source/smbd/posix_acls.c | diffblobblamehistory |