ldb: Log the partition we're repacking
commit18fb5fb911d098701e4af732977310e48ed403a9
authorTim Beale <timbeale@catalyst.net.nz>
Tue, 30 Jul 2019 22:33:49 +0000 (31 10:33 +1200)
committerKarolin Seeger <kseeger@samba.org>
Mon, 26 Aug 2019 07:06:18 +0000 (26 07:06 +0000)
tree2c13979272950e50d25ac2a01fa2c27e71813c4d
parent1c2f1bd04abbedb3cfb31bb4a0ee4292c21dacc4
ldb: Log the partition we're repacking

Firstly, with Samba AD this looks a little weird because we log the same
message 5 times (once for every partition). If we log that we're doing
this to records in different partitions, hopefully someone with a little
Samba knowledge can figure out what's going on.

Secondly, the info about what partitions are actually changing might be
useful. E.g. if we hit a fatal error repacking the 3rd partition, and
the transaction doesn't abort properly, then it would be useful to know
what partitions were repacked and which ones weren't.

There doesn't appear to be a useful name for the partition
(ldb_kv->kv_ops->name() doesn't seem any more intelligible to a user),
so just log the first record that we update. We can use that to infer
the partition database).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
(cherry picked from commit ee6537c29e747206ee607493ce15d4532fb670c8)
lib/ldb/ldb_key_value/ldb_kv_index.c