| commit | 14e534a8907c34b53e00a63756efd71903ff9432 | |
| author | Andrew Tridgell <tridge@samba.org> | |
| Mon, 28 Aug 2000 04:42:31 +0000 (28 04:42 +0000) | ||
| committer | Andrew Tridgell <tridge@samba.org> | |
| Mon, 28 Aug 2000 04:42:31 +0000 (28 04:42 +0000) | ||
| tree | f8fe1ed9138c6aee739e43c61768287f8e8bce9a | treesnapshot (tar.gz zip) |
| parent | f99f028c77482e591741df2a3da7f036f7409a68 | commitdiff |
yipee!
The spoolss AddJob function has an [in,out] buffer not an [in] buffer
(despite the comment in the code to the contrary). Also, we must fail
this function - not just blindly reply "no problem" as AddJob should
always fail on non-local printers.
This fixes a bug where the "print test page" failed about half the
time. I suspect it will also fix a bunch of other intermittent spoolss
bugs where the client (incorrectly) tries to use the AddJob printing
interface.
The spoolss AddJob function has an [in,out] buffer not an [in] buffer
(despite the comment in the code to the contrary). Also, we must fail
this function - not just blindly reply "no problem" as AddJob should
always fail on non-local printers.
This fixes a bug where the "print test page" failed about half the
time. I suspect it will also fix a bunch of other intermittent spoolss
bugs where the client (incorrectly) tries to use the AddJob printing
interface.