| commit | 10996c444fcb7e2418c3e8f396cc631f6b325786 | |
| author | Steven Danneman <steven.danneman@isilon.com> | |
| Wed, 3 Sep 2008 22:31:39 +0000 (3 15:31 -0700) | ||
| committer | Jeremy Allison <jra@samba.org> | |
| Thu, 4 Sep 2008 18:50:13 +0000 (4 11:50 -0700) | ||
| tree | 872f4f297b2c68d0221a6dbf6b4e26e1693f7f63 | treesnapshot (tar.gz zip) |
| parent | b737b0869066eafe5af4518692ec0a1522387031 | commitdiff |
Cleanup of DC enumeration in get_dcs()
This is a fix for a few small inefficiencies/bugs in the get_dcs() path.
* because the third add_one_dc_unique() loop was outside the ADS check all DCs
returned from the non-sitename lookup were being tacked onto the dc_name_ip
list twice.
* add_one_dc_unique() now checks if the given IP address already exists before
adding it to the list, making the returned list actually unique
* added more thorough doxygen comment headers
This is a fix for a few small inefficiencies/bugs in the get_dcs() path.
* because the third add_one_dc_unique() loop was outside the ADS check all DCs
returned from the non-sitename lookup were being tacked onto the dc_name_ip
list twice.
* add_one_dc_unique() now checks if the given IP address already exists before
adding it to the list, making the returned list actually unique
* added more thorough doxygen comment headers
| source/lib/util_sock.c | diffblobblamehistory | |
| source/libsmb/conncache.c | diffblobblamehistory | |
| source/winbindd/winbindd_cm.c | diffblobblamehistory |